Skip to content

Revert big NPM package#61

Merged
asus4 merged 2 commits intomainfrom
revert-big-npm-package
Apr 3, 2025
Merged

Revert big NPM package#61
asus4 merged 2 commits intomainfrom
revert-big-npm-package

Conversation

@asus4
Copy link
Owner

@asus4 asus4 commented Apr 3, 2025

This PR reverts changes in #60 and stops publishing oversized packages again.

See the CI Log for more detail:

npm notice unpacked size: 343.7 MB
npm notice total files: 15
npm notice Publishing to https://registry.npmjs.org/ with tag latest and default access
npm error code E413
npm error 413 Payload Too Large - PUT https://registry.npmjs.org/com.github.asus4.onnxruntime.linux-x64-gpu - Payload Too Large

@asus4 asus4 requested a review from Copilot April 3, 2025 15:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts changes introduced in #60 by updating package versions and disabling the publishing of oversized packages.

  • Bumps dependency versions in README.md from 0.3.4 to 0.3.5
  • Comments out publishing steps for linux-x64-gpu and win-x64-gpu in the workflow to prevent oversized package uploads

Reviewed Changes

Copilot reviewed 2 out of 8 changed files in this pull request and generated 2 comments.

File Description
README.md Updated dependency versions to reflect reversion
.github/workflows/publish-packages.yml Disabled publishing for oversized packages
Files not reviewed (6)
  • com.github.asus4.onnxruntime-extensions/package.json: Language not supported
  • com.github.asus4.onnxruntime-genai/package.json: Language not supported
  • com.github.asus4.onnxruntime.linux-x64-gpu/package.json: Language not supported
  • com.github.asus4.onnxruntime.unity/package.json: Language not supported
  • com.github.asus4.onnxruntime.win-x64-gpu/package.json: Language not supported
  • com.github.asus4.onnxruntime/package.json: Language not supported

Comment on lines +43 to +44
# publish_npm com.github.asus4.onnxruntime.linux-x64-gpu
# publish_npm com.github.asus4.onnxruntime.win-x64-gpu
Copy link

Copilot AI Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a clarifying comment explaining why these publish steps are commented out, or remove them if they are no longer required, to improve maintainability.

Suggested change
# publish_npm com.github.asus4.onnxruntime.linux-x64-gpu
# publish_npm com.github.asus4.onnxruntime.win-x64-gpu
# publish_npm com.github.asus4.onnxruntime.linux-x64-gpu
# Commented out because GPU packages are not ready for publishing yet.
# publish_npm com.github.asus4.onnxruntime.win-x64-gpu
# Commented out because GPU packages are not ready for publishing yet.

Copilot uses AI. Check for mistakes.
@asus4 asus4 merged commit 2e062f2 into main Apr 3, 2025
1 check passed
@asus4 asus4 deleted the revert-big-npm-package branch April 3, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant