Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts changes introduced in #60 by updating package versions and disabling the publishing of oversized packages.
- Bumps dependency versions in README.md from 0.3.4 to 0.3.5
- Comments out publishing steps for linux-x64-gpu and win-x64-gpu in the workflow to prevent oversized package uploads
Reviewed Changes
Copilot reviewed 2 out of 8 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Updated dependency versions to reflect reversion |
| .github/workflows/publish-packages.yml | Disabled publishing for oversized packages |
Files not reviewed (6)
- com.github.asus4.onnxruntime-extensions/package.json: Language not supported
- com.github.asus4.onnxruntime-genai/package.json: Language not supported
- com.github.asus4.onnxruntime.linux-x64-gpu/package.json: Language not supported
- com.github.asus4.onnxruntime.unity/package.json: Language not supported
- com.github.asus4.onnxruntime.win-x64-gpu/package.json: Language not supported
- com.github.asus4.onnxruntime/package.json: Language not supported
Comment on lines
+43
to
+44
| # publish_npm com.github.asus4.onnxruntime.linux-x64-gpu | ||
| # publish_npm com.github.asus4.onnxruntime.win-x64-gpu |
There was a problem hiding this comment.
Please add a clarifying comment explaining why these publish steps are commented out, or remove them if they are no longer required, to improve maintainability.
Suggested change
| # publish_npm com.github.asus4.onnxruntime.linux-x64-gpu | |
| # publish_npm com.github.asus4.onnxruntime.win-x64-gpu | |
| # publish_npm com.github.asus4.onnxruntime.linux-x64-gpu | |
| # Commented out because GPU packages are not ready for publishing yet. | |
| # publish_npm com.github.asus4.onnxruntime.win-x64-gpu | |
| # Commented out because GPU packages are not ready for publishing yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts changes in #60 and stops publishing oversized packages again.
See the CI Log for more detail: