Build patch to fix wierd problem in ExternalProject

[acochrane]

Abs isn't imported by common_math.py in the ExternalProject libsurvive

It looks like my setup doesn't recognize the existing gen.h files and tries but fails to build them because kalman_kinematics.py doesn't have access to Abs from cnkalman.codegen

[asymingt]

Hey @acochrane thanks for the PR!

I haven't used the HIDAPI version of libsurvive, but if we make this change, then at a minimum we're also going to have to do this to make sure the docker container adds two libraries in support of this mode:

diff --git a/Dockerfile b/Dockerfile
index 8b02451..873116e 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -34,9 +34,11 @@ RUN apt-get update && apt-get install -y --no-install-recommends
         freeglut3-dev                                                           \
         gdb                                                                     \
         libatlas-base-dev                                                       \
+        libhidapi-dev                                                           \
         liblapacke-dev                                                          \
         libopenblas-dev                                                         \
         libpcap-dev                                                             \
+        libudev-dev                                                             \
         libusb-1.0-0-dev                                                        \
         libx11-dev                                                              \
         sudo                                                                    \

I'll try and test your code this week to make sure it works locally. I also need to work out why CI doesn't seem to be building your branch. If it did, you'd see a build failure right now because of the Dockerfile issue above!

[acochrane]

Hey @asymingt,
Agreed on HIDAPI adding complexity, in fact it only solved my issue for a little while.
I'm going to try something else, meanwhile I have reverted my pull request to only include the fix the the missing import of Abs

[asymingt]

Thanks for tracking this down as an upstream bug in libsurvive, which has subsequently been resolved. To avoid this happening again, I have a PR that will pin to a specific commit on master: #17