Skip to content

fix(react): resolve default re-export bindings from imported identifiers #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
async3619 merged 1 commit into from
Mar 21, 2026
Merged

fix(react): resolve default re-export bindings from imported identifiers #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions src/analyzers/react/bindings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,13 @@ export function collectImportsAndExports(
collectExportAllBindings(statement, sourceDependencies, exportAllBindings)
return
case 'ExportDefaultDeclaration':
collectDefaultExport(statement, symbolsByName, exportsByName)
collectDefaultExport(
statement,
symbolsByName,
importsByLocalName,
exportsByName,
reExportBindingsByName,
)
return
default:
return
Expand Down Expand Up @@ -198,7 +204,9 @@ function collectExportAllBindings(
function collectDefaultExport(
declaration: ExportDefaultDeclaration,
symbolsByName: ReadonlyMap<string, PendingReactUsageNode>,
importsByLocalName: ReadonlyMap<string, ImportBinding>,
exportsByName: Map<string, string>,
reExportBindingsByName: Map<string, ImportBinding>,
): void {
if (
declaration.declaration.type === 'FunctionDeclaration' ||
Expand All @@ -212,12 +220,15 @@ function collectDefaultExport(
}

if (declaration.declaration.type === 'Identifier') {
addExportBinding(
declaration.declaration.name,
'default',
symbolsByName,
exportsByName,
)
const localName = declaration.declaration.name
addExportBinding(localName, 'default', symbolsByName, exportsByName)

if (!exportsByName.has('default')) {
const importBinding = importsByLocalName.get(localName)
if (importBinding !== undefined) {
reExportBindingsByName.set('default', importBinding)
}
}
return
}

Expand Down
Loading