fix: make tools dashboard filter controls keyboard accessible#5224
fix: make tools dashboard filter controls keyboard accessible#5224Oluwatunmise-olat wants to merge 1 commit intoasyncapi:masterfrom
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ToolsDashboard component's Filter and Jump to Category controls are converted from non-interactive divs to semantic button elements with ARIA attributes for improved keyboard accessibility. Filter popup wrapper is changed from a button to a properly structured div. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5224 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 796 796
Branches 146 146
=========================================
Hits 796 796 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5224--asyncapi-website.netlify.app/ |



Description
/toolsdivtriggers with semantic<button type="button">for:FilterJump to Category<Filters />from<button>to<div>aria-expandedaria-controlsClear Filtersto use a keyboard-accessible button controlWhy this change
The previous implementation relied on clickable
divelements and included abuttonwrapping interactive children. This can cause inconsistent keyboard behavior and accessibility issues for assistivetechnologies.
Testing done
npm run lint(existing repo warnings only)npm run test -- --runInBand(all test suites passed locally)/tools:Scope
components/tools/ToolsDashboard.tsxRelated issue(s)
Fixes #5223
Summary by CodeRabbit