fix: typo in publish-subscribe-semantics.md#5251
fix: typo in publish-subscribe-semantics.md#5251kletnoe wants to merge 2 commits intoasyncapi:masterfrom
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughA typo correction in a blog post about pub-sub messaging semantics, changing "s messaging infrastructure" to "a messaging infrastructure" in a single sentence. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use oxc to improve the quality of JavaScript and TypeScript code reviews.Add a configuration file to your project to customize how CodeRabbit runs oxc. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5251 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 830 830
Branches 159 159
=========================================
Hits 830 830 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
markdown/blog/publish-subscribe-semantics.md (1)
57-57: Consider hyphenating "event-driven" for grammatical correctness.The phrase "event driven architecture" should use a hyphen when the compound adjective precedes the noun. As per static analysis tools, this improves grammatical correctness in technical documentation.
📝 Suggested grammar improvement
-In an event driven architecture there is no client/server paradigm. Applications do not directly communicate with one another - instead, each application sends and receives events via communication channels provided by a messaging infrastructure such as a broker. The broker ensures that events sent to a channel are delivered to interested applications. It can be considered *fire and forget* - an application sends an event, but does not have any interest in whether other applications receive or make use of the event. +In an event-driven architecture there is no client/server paradigm. Applications do not directly communicate with one another - instead, each application sends and receives events via communication channels provided by a messaging infrastructure such as a broker. The broker ensures that events sent to a channel are delivered to interested applications. It can be considered *fire and forget* - an application sends an event, but does not have any interest in whether other applications receive or make use of the event.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@markdown/blog/publish-subscribe-semantics.md` at line 57, Replace the unhyphenated adjective phrase "event driven architecture" with "event-driven architecture" in the sentence that begins "In an event driven architecture..." (the paragraph describing applications sending and receiving events via a broker); also scan for any other occurrences of "event driven" in this document and hyphenate them when used as a compound adjective to conform to grammar/style guidance.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@markdown/blog/publish-subscribe-semantics.md`:
- Line 57: Replace the unhyphenated adjective phrase "event driven architecture"
with "event-driven architecture" in the sentence that begins "In an event driven
architecture..." (the paragraph describing applications sending and receiving
events via a broker); also scan for any other occurrences of "event driven" in
this document and hyphenate them when used as a compound adjective to conform to
grammar/style guidance.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5b196992-150b-4b69-aa11-508aa8c22e19
📒 Files selected for processing (1)
markdown/blog/publish-subscribe-semantics.md
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5251--asyncapi-website.netlify.app/ |
princerajpoot20
left a comment
princerajpoot20
left a comment
There was a problem hiding this comment.
@kletnoe please update the PR title according the convention mentioned by the BOT above. Also from next time, please preffer to open issue first, and not PR directly.
@thulieblack @TRohit20 PTAL
kletnoe
changed the title
|
/rtm |
|
Hello, @animeshk923! 👋🏼 |
|
This comment was marked as outdated.
This comment was marked as outdated.
|
/au |
4 participants
Description
Summary by CodeRabbit
Documentation