docs(validate): fix Spectral config examples to use YAML syntax#5273
docs(validate): fix Spectral config examples to use YAML syntax#5273DeekRoumy wants to merge 2 commits intoasyncapi:masterfrom
Conversation
The .spectral.yaml file examples in the validate guide were written in JSON syntax, which is inconsistent with the .yaml file extension and can confuse contributors. Converts both Spectral configuration examples to valid YAML format. Fixes asyncapi#5117
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughUpdated the Spectral configuration example in the validation guide from JSON/JavaScript object syntax to valid YAML syntax to match the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5273 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 830 830
Branches 159 159
=========================================
Hits 830 830 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5273--asyncapi-website.netlify.app/ |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@markdown/docs/guides/validate.md`:
- Around line 66-77: Indent the fenced YAML block so it is nested under the
numbered list item (step 3) — add the same leading indentation used by the list
item to the opening ```yaml fence, each line of the YAML (rules: ... match:
"^[A-Z]"), and the closing ``` fence so the entire block is rendered as part of
the list. Locate the triple-backtick YAML block containing "rules:
valid-document-version: ..." and adjust its indentation consistently to match
the surrounding list indentation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d51dccc0-736a-43d2-aece-693102dc0f37
📒 Files selected for processing (1)
markdown/docs/guides/validate.md
|
please do not open vague pr , issue has not been approved yet |
CodeRabbit flagged that the YAML block was not properly nested under list item 3, causing rendering issues. Added proper 3-space indentation to align the fenced block with its parent list item. Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|



Summary
Fixes #5117
The
.spectral.yamlfile examples in the validate guide were written in JSON syntax, which is inconsistent with the.yamlfile extension.Changes
markdown/docs/guides/validate.mdfrom JSON syntax to valid YAML syntaxjstoyamlWhy this matters
New contributors following the guide may copy the JSON example and create an invalid
.spectral.yamlfile, causing Spectral to fail or behave unexpectedly.Before / After
Before:
After:
Summary by CodeRabbit