docs(i18n): fix config filename references in ADDING_TRANSLATIONS.md#5274
docs(i18n): fix config filename references in ADDING_TRANSLATIONS.md#5274DeekRoumy wants to merge 2 commits intoasyncapi:masterfrom
Conversation
…S.md The guide referenced two different filenames for the i18n config: - 'next-i18next-static-site.config.js' (in Adding translations to new page) - 'next-i18next.config.js' (in Adding a new locale) The actual file in the repository is 'next-i18next.config.cjs'. Updated all references to use the correct filename. Fixes asyncapi#5111
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the translation guide to consistently reference Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5274 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 830 830
Branches 159 159
=========================================
Hits 830 830 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ADDING_TRANSLATIONS.md`:
- Around line 255-257: Update the docs to reference the actual config keys used
in next-i18next.config.cjs: replace instructions that say to edit `languages`
and `defaultLanguage` with the correct property names `locales` and
`defaultLocale` (and mention the file `next-i18next.config.cjs`) so contributors
are directed to modify `locales` array and `defaultLocale` value instead; apply
the same correction to the repeated section later in the doc (lines ~281-299).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2386b056-ecea-4d57-970a-9ce5cfcd9f55
📒 Files selected for processing (1)
ADDING_TRANSLATIONS.md
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5274--asyncapi-website.netlify.app/ |
…onfig.cjs CodeRabbit flagged that the docs referenced 'languages' and 'defaultLanguage' but the actual config file uses 'locales' and 'defaultLocale'. Updated all references throughout the document to match the real config keys. Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
|



Summary
Fixes #5111
The
ADDING_TRANSLATIONS.mdguide referenced two different (incorrect) filenames for the i18n configuration file, causing confusion for contributors.Problem
next-i18next-static-site.config.jsnext-i18next.config.jsnext-i18next.config.cjsChanges
Updated all 4 filename references in
ADDING_TRANSLATIONS.mdto consistently usenext-i18next.config.cjs.Why this matters
Contributors following the guide to add translations or new locales would navigate to the wrong file, leading to confusion or setup failures.
Summary by CodeRabbit