Release/3.1 refactor base path resolve in frontend #22
Conversation
…image optimization tool from the `exeimage` plugin.
…elative to their container to avoid breaking the layout.
…en an image has no alternative text.
…o 1023-tinymce-plugins-integrate-v302-fixes
…ithub.com/exelearning/exelearning into 1023-tinymce-plugins-integrate-v302-fixes
… show image in preview after insert'.
…inymce-issues-when-using-a-different-base_path
…f github.com:exelearning/exelearning into 1042-tinymce-issues-when-using-a-different-base_path
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9df16db37
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| includeMathJax: meta.addMathJax === true, | ||
| // Don't skip MathJax if explicitly requested via addMathJax | ||
| skipMathJax: latexWasRendered && !meta.addMathJax, | ||
| // Always skip Mermaid - eXeLearning ALWAYS pre-renders to SVG (~2.7MB saved) | ||
| skipMermaid: true, |
There was a problem hiding this comment.
This forces skipMermaid to true for every export, but preRenderMermaid is only wired in the browser export path and can be absent or fail when Mermaid isn’t loaded. In server/CLI exports (or browser exports without a working pre-render hook), the HTML can still contain <pre class="mermaid"> while the Mermaid library is never bundled, so diagrams render as raw text. Consider skipping Mermaid only when pre-rendering actually succeeded (or when you can guarantee the library is available elsewhere).
Useful? React with 👍 / 👎.
… and avoid exporting asset:// urls
…b.com:exelearning/exelearning into 1052-image-gallery-images-not-visible-importing-elp-29
…into 1052-image-gallery-images-not-visible-importing-elp-29
…b.com:exelearning/exelearning into 1058-images-missing-when-exporting-pages-from-older-resources
…m-older-resources
… of github.com:exelearning/exelearning into 1052-image-gallery-images-not-visible-importing-elp-29
…m-older-resources
…m-older-resources Resolved conflicts: - workarea-helpers.ts: Kept exportPage() helper and added block icon helpers - component-export-import.spec.ts: Added block icon helper imports and tests
…ources' of github.com:exelearning/exelearning into 1052-image-gallery-images-not-visible-importing-elp-29
Combines assetExportPathMap for URL transformation with themeIcons for icon extensions.
…base-path-resolve-in-frontend # Conflicts: # src/shared/export/exporters/Html5Exporter.ts # src/shared/export/interfaces.ts # src/shared/export/renderers/IdeviceRenderer.ts # src/shared/export/renderers/PageRenderer.ts
No description provided.