fix: use OR logic for domain_guids filter in search_assets#214
Open
mothership-ai[bot] wants to merge 1 commit intomainfrom
Open
fix: use OR logic for domain_guids filter in search_assets#214mothership-ai[bot] wants to merge 1 commit intomainfrom
mothership-ai[bot] wants to merge 1 commit intomainfrom
Conversation
The domain_guids filter was applying AND logic by iterating over each GUID and adding a separate .where() clause. This meant an asset would need to belong to ALL specified domains simultaneously to match, which is incorrect — it should match assets in ANY of the provided domains. Replace the loop with a single Asset.DOMAIN_GUIDS.within(domain_guids) call that uses Elasticsearch Terms query (OR logic). Fixes: LINTEST-563 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session owner: @viswesh
Summary
domain_guidsfilter insearch_assetsto use OR logic instead of AND.where(Asset.DOMAIN_GUIDS.eq(guid))required assets to match ALL domains simultaneouslyAsset.DOMAIN_GUIDS.within(domain_guids)which matches assets in ANY of the provided domainsContext
When an AI agent (MCP/Chat) finds DataDomains and then searches for DataProducts linked to those domain GUIDs, the AND logic causes 0 results because no asset belongs to multiple domains at once. The customer (Edenred) reported this as inability to list DataProducts under SmartER domains.
Fixes: LINTEST-563
Test plan
🤖 Generated with Claude Code