Closed
Conversation
Remove all deprecated v2 modules that have been superseded by v3 equivalents. This includes activities/, application/, workflows/, handlers/, interceptors/, deprecated client files, worker.py, the deprecated APIServer, and deprecated test utilities. Key changes: - Relocate workflows/outputs/ to application_sdk/outputs/ (active code) - Update non-deprecated imports to use v3 paths (handler.base.Handler, contracts.events, execution._temporal.activity_utils) - Remove deprecated register_tools() from MCP server (v3 uses register_tools_from_registry) - Clean up server/fastapi/models.py (remove WorkflowTrigger classes) - Delete ~23K lines of deprecated source and test code Deferred (still actively used by v3 code): - services/objectstore.py, statestore.py, secretstore.py - test_utils/hypothesis/, test_utils/e2e/
…eprecated-v2-modules
- standards/documentation.md: replace deleted v2 module-to-doc mappings with v3 equivalents (app/, handler/, templates/, execution/, etc.) - standards/exceptions.md: update directory paths (handlers/ -> handler/, workflows/ -> app/task.py) - concepts/clients.md: remove deleted TemporalWorkflowClient, WorkflowClient, get_workflow_client sections; point to execution module
…MetadataExtractor
Introduces declarative entity definitions that replace hardcoded
asyncio.gather of 4 entities in SqlMetadataExtractor.run().
- EntityDef dataclass: name, sql, endpoint, phase, enabled, timeout
- Phased orchestration: entities grouped by phase, run concurrently
within phase, sequentially across phases
- _fetch_entity() dispatches to fetch_{name}() methods by convention
- Full backward compat: empty entities list falls back to default 4
(databases, schemas, tables, columns)
- Adding a new entity type is one line in the entities list
What a Snowflake extractor looks like:
class SnowflakeExtractor(SqlMetadataExtractor):
entities = [
EntityDef(name="databases", phase=1),
EntityDef(name="schemas", phase=1),
EntityDef(name="stages", phase=2),
EntityDef(name="streams", phase=2),
]
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Collaborator
|
@AtMrun — do we still need this? Feels like this PR is a combination of probably two separate PRs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Additional context (e.g. screenshots, logs, links)
Checklist
Copyleft License Compliance