fix(tools): eliminate false positive warnings in v3 readiness check [BLDX-1115]#1517
Merged
Aryamanz29 merged 7 commits intomainfrom Apr 22, 2026
Merged
fix(tools): eliminate false positive warnings in v3 readiness check [BLDX-1115]#1517Aryamanz29 merged 7 commits intomainfrom
Aryamanz29 merged 7 commits intomainfrom
Conversation
… [BLDX-1115] - Skip .github/, .venv/, local/, node_modules/ etc. when checking for v2 "activities"/"workflows" directories — these are not v2 artifacts - Skip response-format-change warning for fetch_metadata/preflight_check when the handler already uses v3 typed contracts (MetadataInput/PreflightInput) - Fully migrated v3 connectors can now produce a clean readiness report
Aryamanz29
requested review from
OnkarVO7,
atlan-ci,
cmgrote,
louisnow and
vaibhavatlan
as code owners
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
📜 Docstring Coverage ReportRESULT: PASSED (minimum: 30.0%, actual: 80.1%) Detailed Coverage Report |
Contributor
📦 Trivy Vulnerability Scan Results
Report SummaryCould not generate summary table (data length mismatch: 9 vs 8). Scan Result Detailsrequirements.txtuv.lock |
Contributor
📦 Trivy Secret Scan Results
Report SummaryCould not generate summary table (data length mismatch: 9 vs 8). Scan Result Detailsrequirements.txtuv.lock |
Collaborator
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Contributor
|
🛠 Full Test Coverage Report: https://k.atlan.dev/coverage/application-sdk/pr/1517 |
Member
Author
|
@sdk-review |
Contributor
|
🔄 SDK Review starting (review) — ~10 min. Watch live progress |
Contributor
SDK Review: PR #1517 — fix(tools): eliminate false positive warnings in v3 readiness check [BLDX-1115]Verdict: READY TO MERGE
Findings by File
Strengths
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
atlan-ci
approved these changes
Apr 22, 2026
Collaborator
atlan-ci
left a comment
atlan-ci
left a comment
There was a problem hiding this comment.
SDK Review: no blocking issues found. CI passing. Branch up to date. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 3 false positive warnings that fire on every fully-migrated v3 connector, making it impossible to get a clean readiness report.
Closes #1497
Changes
1.
.github/workflowsno longer flagged as v2 directoryThe
no-v2-directory-structurecheck now skips non-source directories (.github/,.venv/,local/,node_modules/,.out/,artifacts/,.cache/). Previously any directory namedworkflowsanywhere in the repo triggered the warning.2.
response-format-changesuppressed for v3-migrated handlersThe warning now only fires when the handler method signature has NOT been migrated to v3 typed contracts. If the signature already uses
MetadataInput/PreflightInput, the handler is properly migrated and no warning is emitted.Before → After
A fully migrated connector (e.g. atlan-azure-event-hub-app) now produces 0 false positives from these 3 checks instead of 3.
Linear
https://linear.app/atlan-epd/issue/BLDX-1115