feat: Using Pubsub for message processors#898
Merged
inishchith merged 2 commits intomainfrom Jan 14, 2026
Merged
Conversation
Contributor
📜 Docstring Coverage ReportRESULT: PASSED (minimum: 30.0%, actual: 77.4%) Detailed Coverage Report |
Contributor
📦 Trivy Vulnerability Scan Results
Report Summary
Scan Result Details✅ No vulnerabilities found during the scan for |
Contributor
📦 Trivy Secret Scan Results
Report Summary
Scan Result Details✅ No secrets found during the scan for |
Contributor
|
🛠 Docs available at: https://k.atlan.dev/application-sdk/add-message-processor |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Collaborator
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Contributor
|
🛠 Full Test Coverage Report: https://k.atlan.dev/coverage/application-sdk/pr/898 |
niteesh-atlan
changed the title
niteesh-atlan
requested review from
AtMrun,
firecast and
inishchith
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces Pub/Sub messaging support for message processors using Dapr, enabling applications to subscribe to message topics and process incoming messages through configurable handlers.
Key changes:
- Added Dapr pubsub component configuration with support for both in-memory and Kafka backends
- Introduced
PubSubSubscriptionandBulkSubscribemodels for configuring message subscriptions - Implemented automatic registration of message handler endpoints and Dapr subscription generation
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| components/messaging.yaml | New Dapr pubsub component configuration file with in-memory and commented Kafka configurations |
| components/eventstore.yaml | Minor formatting fix to ensure both webhook URLs remain commented out |
| application_sdk/server/fastapi/models.py | Added BulkSubscribe and PubSubSubscription models to support message subscription configuration |
| application_sdk/server/fastapi/init.py | Integrated messaging subscriptions into server initialization, router registration, and Dapr subscription endpoint |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
niteesh-atlan
changed the title
3 tasks
firecast
reviewed
Jan 6, 2026
Member
firecast
left a comment
firecast
left a comment
There was a problem hiding this comment.
We also need docs on how can the handlers be written and a typedefinition defined for it as arguments so that handlers are specific
niteesh-atlan
requested review from
abhishekagrawal-atlan,
Copilot and
firecast
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
application_sdk/server/fastapi/init.py:127
- The docstring for the init method is incomplete. It only documents three parameters (lifespan, handler, workflow_client) but the method signature includes additional parameters: frontend_templates_path, ui_enabled, has_configmap, and the newly added messaging_subscriptions. All parameters should be documented in the Args section of the docstring for clarity and maintainability.
"""Initialize the FastAPI application.
Args:
lifespan: Optional lifespan manager for the FastAPI application.
handler: Handler for processing application operations.
workflow_client: Client for Temporal workflow operations.
"""
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
firecast
requested changes
Jan 8, 2026
niteesh-atlan
commented
Jan 9, 2026
firecast
previously approved these changes
Jan 12, 2026
- Add Subscription model with BulkConfig and MessageStatus nested classes - Rename PubSubSubscription to Subscription with simplified field names - Add subscription routes under /subscriptions/v1 prefix - Support sync and async message handlers - Add bulk subscribe configuration with Dapr-compatible serialization - Add dead letter topic support - Add comprehensive unit tests for subscription functionality - Update server documentation
niteesh-atlan
force-pushed
the
add-message-processor
branch
from
335ae94 to
227bbcf
Compare
Contributor
📦 Example workflows test results
|
Contributor
📦 Example workflows test results
|
Contributor
📦 Example workflows test results
|
firecast
approved these changes
Jan 13, 2026
inishchith
approved these changes
Jan 14, 2026
inishchith
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
APP-9587 : Using Pubsub for message processors
Scope
Sample app Pr - atlanhq/atlan-sample-apps#119
Additional context (e.g. screenshots, logs, links)
Checklist
Copyleft License Compliance