Skip to content

HACK: Support eclipe.jdt.ls's break with the LSP spec #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

HACK: Support eclipe.jdt.ls's break with the LSP spec #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions lib/adapters/code-action-adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,20 @@ export default class CodeActionAdapter {
connection: LanguageClientConnection,
): Promise<void> {
if (Command.is(command)) {
await connection.executeCommand({
command: command.command,
arguments: command.arguments,
});
// eclipse.jdt.ls breaks with the spec and expects the client to handle the command
// https://github.com/eclipse/eclipse.jdt.ls/issues/376
if (command.command === 'java.apply.workspaceEdit') {
if (command.arguments) {
// Guaranteed only ever one element in the arguments array
const edit: WorkspaceEdit = command.arguments[0];
CodeActionAdapter.applyWorkspaceEdit(edit);
}
} else {
await connection.executeCommand({
command: command.command,
arguments: command.arguments,
});
}
}
}

Expand Down