-
Notifications
You must be signed in to change notification settings - Fork 69
New Document Editor + Yjs type #998 #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@cursor review |
PR SummaryAdds YDoc/Yjs across the stack (datatype, commits/yUpdate, WS sync, search indexing, CLI input) and updates React hooks while bumping React to 19.2.
Written by Cursor Bugbot for commit 993bed2. This will update automatically on new commits. Configure here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| serverUrl, | ||
| }); | ||
|
|
||
| await enableYjs(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Top-Level Await Disrupts System Initialization
Top-level await enableYjs() call makes the module async, causing potential issues with React and build tool initialization. This should be called within a React effect or effect hook instead, or handled during store initialization within the App component.
Related Issues
relates to #998
closes #720, closes #1111, closes #741
Checklist