fix(gov): preserve SDK-only cancel fields in legacy param updates#303
Closed
fix(gov): preserve SDK-only cancel fields in legacy param updates#303
Conversation
…el defaults in v4
Pantani
requested review from
giuliostramondo,
giunatale,
jaekwon and
tbruyelle
as code owners
Collaborator
|
Is it related to an audit finding ? |
Collaborator
|
This seems to clash with #306 which was fixing A-35. |
Contributor
Author
This is a follow-up fix for issues found while reviewing PR #300 |
Contributor
Author
Should I close this one? |
Collaborator
Pantani
changed the title
Contributor
Author
@tbruyelle, I made a change, this PR is now scoped solely to the government compatibility fix. |
Collaborator
|
@Pantani Have you seen atomone-hub/cosmos-sdk#85 ? Does that make this PR irrelevant ? |
Collaborator
|
Basically yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR preserves the SDK-only
ProposalCancelRatioandProposalCancelDestfields when converting and handling legacyatomone.gov.v1.MsgUpdateParams, so legacy param updates stay valid without overlapping with theapp/upgrades/v4change now covered by #306.