fix(x/gov): validate minimum self-delegation for imported governors in InitGenesis#71
Open
giunatale wants to merge 2 commits intorelease/v0.50.xfrom
Open
fix(x/gov): validate minimum self-delegation for imported governors in InitGenesis#71giunatale wants to merge 2 commits intorelease/v0.50.xfrom
InitGenesis#71giunatale wants to merge 2 commits intorelease/v0.50.xfrom
Conversation
giunatale
requested review from
Pantani,
giuliostramondo,
julienrbrt and
tbruyelle
as code owners
This comment has been minimized.
This comment has been minimized.
tbruyelle
approved these changes
Mar 18, 2026
Pantani
reviewed
Mar 20, 2026
| } | ||
|
|
||
| // set governors | ||
| minSelfDelegation, _ := math.NewIntFromString(data.Params.MinGovernorSelfDelegation) |
Collaborator
Author
There was a problem hiding this comment.
no?!?!
why? Params are validated beforehand.
Why should we?
There was a problem hiding this comment.
An invalid parameter can be marshaled from an invalid genesis file. It would be better if we had a clearer error description about the issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix A-28