Skip to content

Revert to 2-arg open in one case. GH #1 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atoomic wants to merge 1 commit into
base: demo-blead
Choose a base branch
from
Open

Revert to 2-arg open in one case. GH #1 #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions dist/Term-ReadLine/lib/Term/ReadLine.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,10 +267,13 @@ sub new {
my($console, $consoleOUT) = $_[0]->findConsole;




# the Windows CONIN$ needs GENERIC_WRITE mode to allow
# a SetConsoleMode() if we end up using Term::ReadKey
open FIN, (( $^O eq 'MSWin32' && $console eq 'CONIN$' ) ? '+<' : '<' ), $console;
open FOUT,'>', $consoleOUT;
# RT #132008: Still need 2-arg open here
open FOUT,">$consoleOUT";

#OUT->autoflush(1); # Conflicts with debugger?
my $sel = select(FOUT);
Expand Down Expand Up @@ -319,7 +322,7 @@ sub Features { \%features }

package Term::ReadLine; # So late to allow the above code be defined?

our $VERSION = '1.16';
our $VERSION = '1.17';

my ($which) = exists $ENV{PERL_RL} ? split /\s+/, $ENV{PERL_RL} : undef;
if ($which) {
Expand Down