Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the company selection functionality to use a new Record Combobox component, replacing the previous decorated combobox implementation. The change simplifies the component by removing custom options provider logic in favor of built-in record type functionality.
- Replace deprecated
ComboboxwithExperimental_RecordCombobox - Remove custom
companiesProviderand related search/option logic - Update package dependency to support new Record Combobox features
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/log-customer-request-dialog.tsx | Adds Experimental_RecordCombobox to form components and passes it to CompaniesCombobox |
| src/components/comboboxes/companies-options-provider.ts | Removes entire custom options provider implementation |
| src/components/comboboxes/companies-combobox.tsx | Simplifies component to use recordTypes="company" instead of custom provider |
| package.json | Updates attio package version to support Record Combobox functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
8376012 to
b603d61
Compare
kasperkristensen
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.