Open
Conversation
auberonedu
reviewed
Jan 7, 2025
Owner
auberonedu
left a comment
auberonedu
left a comment
There was a problem hiding this comment.
Nice job! See comments below.
| String valueAtIndex = arr[2]; | ||
| // Get the length of the array | ||
|
|
||
| int[] length = new int[4]; |
Owner
There was a problem hiding this comment.
This creates a new array. How would you go about finding the length of the existing array arr?
Comment on lines
+39
to
+42
| for (String i : list){ | ||
| System.out.println(); | ||
| System.out.println(i); | ||
| } |
Owner
There was a problem hiding this comment.
Here and throughout your code try to be a bit more consistent in you indentation.
| // Create a HashMap with String keys and Integer values and | ||
| // assign it to a variable of type Map | ||
|
|
||
| HashMap<String, Integer> people = new HashMap<String, Integer>(); |
Owner
There was a problem hiding this comment.
Remember to use interface types (Map)
Comment on lines
+32
to
+34
| for (String i : people.keySet()) { | ||
| System.out.println("key: " + i + " value: " + people.get(i)); | ||
| } |
Owner
There was a problem hiding this comment.
This works! Can you find another method that works directly with the map entries, looping over the keys and values in a single set?
| public static void main(String[] args) { | ||
| // Create a HashSet of Strings and assign it to a variable of type Set | ||
|
|
||
| HashSet<String> helicopters = new HashSet<String>(); |
Owner
There was a problem hiding this comment.
Remember to use interface types (Set)
| } | ||
| // Create an ArrayList of Strings and assign it to a variable | ||
|
|
||
| ArrayList<String> bedroom = new ArrayList<String>(); |
Owner
There was a problem hiding this comment.
Remember to use interface types (List)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some questions I didn't understand if I needed to actually print something unless specifically specified. So I gave what I thought would be a good implementation. It's good practice overall.