This repository was archived by the owner on Jun 16, 2024. It is now read-only.
Fix Makefile for Debian Stretch (stable)#70
Open
haimgel wants to merge 2 commits intoauchter:masterfrom
Open
Conversation
to pip, which cannot work with "--target". Therefore, "make" fails on current Debian stable (Stretch, 9). Just adding "--system" before "-t" fixes that. Yes, it's stupid, but it works. For more info, see: pypa/pip#3826
Owner
|
While this might fix the build for Debian 9's patched pip, it looks like this will break with upstream pip. If adding |
exists for the currently installed pip.
Author
|
Yeah, I wasn't aware that Debian added the whole "--system" option, I thought they just changed the default. In any case, I checked this commit on CentOS and Debian, and it seems to be ok. I think checking whether "--system" option actually exists is less brittle than checking for the specific OS version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debian 9 introduced patch into pip, which auto-adds "--user" parameter
to pip, which cannot work with "--target". Therefore, "make" fails on
current Debian stable (Stretch, 9). Just adding "--system" before "-t"
fixes that. Yes, it's stupid, but it works. For more info, see:
pypa/pip#3826