Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates copyright year ranges to use an open-ended 'present' upper bound and aligns copyright ownership information in both the README and Sphinx configuration. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Consider making the copyright line in
conf.pyconsistent withREADME.mdin terms of year ranges and company-name formatting (including use of commas and wording likeUG (haftungsbeschränkt)vsUG (haftungsbeschraenkt)), so the attribution is uniform across the project.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider making the copyright line in `conf.py` consistent with `README.md` in terms of year ranges and company-name formatting (including use of commas and wording like `UG (haftungsbeschränkt)` vs `UG (haftungsbeschraenkt)`), so the attribution is uniform across the project.
## Individual Comments
### Comment 1
<location> `doc/sphinx/conf.py:6-9` </location>
<code_context>
project = 'openSMILE'
-copyright = '2013-2023 audEERING GmbH and 2008-2013 TU München, MMK'
+copyright = '2016-present, audEERING GmbH and 2013-2015, audEERING UG (haftungsbeschraenkt) and 2008-2013 TU München, MMK'
author = 'Florian Eyben, Felix Weninger, Martin Wöllmer, Björn Schuller'
version = conanfile.OpensmileConan.version
</code_context>
<issue_to_address>
**suggestion (typo):** Consider using the proper umlaut spelling for 'haftungsbeschränkt' for legal/branding accuracy.
If UTF-8 is fully supported in the build and docs pipeline, consider using `haftungsbeschränkt` to reflect the official entity name. If ASCII-only is required here, a brief comment or note in the docs would help prevent oscillating changes in the future.
```suggestion
project = 'openSMILE'
# Note: use proper umlaut spelling to match the official legal entity name.
copyright = '2016-present, audEERING GmbH and 2013-2015, audEERING UG (haftungsbeschränkt) and 2008-2013 TU München, MMK'
author = 'Florian Eyben, Felix Weninger, Martin Wöllmer, Björn Schuller'
version = conanfile.OpensmileConan.version
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
6
to
9
| project = 'openSMILE' | ||
| copyright = '2013-2023 audEERING GmbH and 2008-2013 TU München, MMK' | ||
| copyright = '2016-present, audEERING GmbH and 2013-2015, audEERING UG (haftungsbeschraenkt) and 2008-2013 TU München, MMK' | ||
| author = 'Florian Eyben, Felix Weninger, Martin Wöllmer, Björn Schuller' | ||
| version = conanfile.OpensmileConan.version |
There was a problem hiding this comment.
suggestion (typo): Consider using the proper umlaut spelling for 'haftungsbeschränkt' for legal/branding accuracy.
If UTF-8 is fully supported in the build and docs pipeline, consider using haftungsbeschränkt to reflect the official entity name. If ASCII-only is required here, a brief comment or note in the docs would help prevent oscillating changes in the future.
Suggested change
| project = 'openSMILE' | |
| copyright = '2013-2023 audEERING GmbH and 2008-2013 TU München, MMK' | |
| copyright = '2016-present, audEERING GmbH and 2013-2015, audEERING UG (haftungsbeschraenkt) and 2008-2013 TU München, MMK' | |
| author = 'Florian Eyben, Felix Weninger, Martin Wöllmer, Björn Schuller' | |
| version = conanfile.OpensmileConan.version | |
| project = 'openSMILE' | |
| # Note: use proper umlaut spelling to match the official legal entity name. | |
| copyright = '2016-present, audEERING GmbH and 2013-2015, audEERING UG (haftungsbeschränkt) and 2008-2013 TU München, MMK' | |
| author = 'Florian Eyben, Felix Weninger, Martin Wöllmer, Björn Schuller' | |
| version = conanfile.OpensmileConan.version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures the license year stays always up to date, by setting its upper bound to
-presentin all files.Summary by Sourcery
Chores:
Summary by Sourcery
Update project copyright notices to use an open-ended year range and reflect correct ownership history.
Documentation:
Chores: