Fix failing CI when not tagging a docker image#3100
Merged
sgoggins merged 1 commit intoaugurlabs:mainfrom Apr 2, 2025
Merged
Conversation
Signed-off-by: John Strunk <jstrunk@redhat.com>
fa12c89 to
3b542a4
Compare
Contributor
Author
|
@sgoggins I noticed my PR from yesterday was causing some failed checks. This should fix it. |
Collaborator
|
@JohnStrunk : Just to confirm my understanding here: We will push new images when a new release is tagged now? |
Contributor
Author
|
It should. The tags are applied here, with the final line being the one for releases: tags: |
type=raw,value=devel-latest,enable=${{ (github.event_name == 'push' || github.event_name == 'workflow_dispatch') && github.ref == 'refs/heads/dev' }}
type=raw,value=latest,enable=${{ github.event_name == 'release' }}
type=raw,value=${{ github.event.release.tag_name }},enable=${{ github.event_name == 'release' }}The tags are then provided as a step output to the build/push step as a comma separated list. My change is gating whether we try to push (or only build) based on whether any tags are provided. The release this morning looks like it built & pushed correctly. This change shouldn't interfere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #3093 that attempts to fix the current failing CI due to trying to push a non-tagged docker image.
The following is taken from #3010
The issue is that we are trying to push the image for any non-PR triggered build, but that doesn't match the logic for when we actually tag an image. The logic here will key off of whether we have actually applied a tag with the actual intent to push. (I'm also keeping the
!= pull_requestcheck just to be safe)Notes for Reviewers
Signed commits