fix(domain-server): volume and pvc handling#28
Merged
dataviruset merged 5 commits intomainfrom Feb 9, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes broken volume and PVC handling in the domain-server Helm chart that was exacerbated by a previous merge. The changes include proper validation for StatefulSet configurations, improved volume mounting logic, and corrections to security context and indentation formatting.
Key changes:
- Renamed
statefulSetNameOverridetonameOverridefor clarity and consistency - Added pre-deployment validation to prevent misconfiguration of single PVC with multi-replica StatefulSets
- Refactored volume handling to properly support three scenarios: existing claims, dynamic PVCs for Deployments, and StatefulSet volume claim templates
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| charts/domain-server/Chart.yaml | Incremented chart version to 0.5.4 |
| charts/domain-server/values.yaml | Renamed PVC name override field, updated storage class documentation, and added container security context configuration |
| charts/domain-server/templates/workload.yaml | Added StatefulSet validation, refactored volume mounting logic to handle existing claims and dynamic provisioning, fixed indentation issues |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tatiesmars
approved these changes
Jan 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tatiesmars
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of this code was broken from before and after merging #27 it became worse.
Also fixes some issues with security contexts and some indentation.