feat(reconstruction-server): single command to scale by tatiesmars · Pull Request #29 · aukilabs/helm-charts

tatiesmars · 2026-01-23T05:30:04Z

Converted reconstruction-server to a StatefulSet with a secret pool + HPA

… pool

Copilot

Pull request overview

This PR converts the reconstruction-server from a Deployment to a StatefulSet to enable stable pod identities and integrate a secret pool mechanism for per-pod credentials. The changes support scaling with unique secrets assigned to each pod based on its ordinal index.

Changes:

Converted Kubernetes Deployment to StatefulSet with stable pod identities
Added secret pool configuration to assign unique credentials to each pod based on ordinal
Implemented validation to ensure secretPool.size >= replicaCount and other configuration requirements

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
charts/reconstruction-server/values.yaml	Added replicaCount and secretPool configuration options
charts/reconstruction-server/templates/statefulset.yaml	Converted Deployment to StatefulSet, added secret mounting and credential injection logic
charts/reconstruction-server/templates/_helpers.tpl	Added validation function to enforce secretPool configuration constraints
charts/reconstruction-server/Chart.yaml	Bumped chart and app versions to 0.3.0

Comments suppressed due to low confidence (1)

charts/reconstruction-server/templates/statefulset.yaml:1

The abbreviation 'std' in the namePrefix is ambiguous. Consider using a more descriptive name like 'reconstruction-server-secret-' to clarify that this prefix is for secret resources.

{{- include "reconstruction-server.validate" . }}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-28T06:20:19Z

charts/reconstruction-server/templates/statefulset.yaml

+            - -ec
+          args:
+            - |
+              ordinal="${HOSTNAME##*-}"


The shell parameter expansion assumes HOSTNAME ends with a hyphen followed by digits. If the hostname format is unexpected, the ordinal extraction will fail silently. Consider adding validation or a more explicit error message explaining the expected hostname format (e.g., 'Expected hostname format: -').

Suggested change

ordinal="${HOSTNAME##*-}"

if [ -z "${HOSTNAME}" ]; then

echo "Expected hostname format: <name>-<ordinal>, but HOSTNAME is empty" >&2

exit 1

fi

case "${HOSTNAME}" in

*-[0-9][0-9]*)

ordinal="${HOSTNAME##*-}"

;;

*)

echo "Expected hostname format: <name>-<ordinal>, got '${HOSTNAME}'" >&2

exit 1

;;

esac

Copilot · 2026-01-28T06:20:19Z

charts/reconstruction-server/templates/statefulset.yaml

+              ordinal="${HOSTNAME##*-}"
+              secret_dir="{{ .Values.secretPool.mountPath }}/${ordinal}"
+              if [ -z "${ordinal}" ] || [ ! -d "${secret_dir}" ]; then
+                echo "missing secret directory for pod ordinal ${ordinal}" >&2


When ordinal is empty due to hostname parsing failure, the error message 'missing secret directory for pod ordinal' is misleading. Consider updating to 'Failed to extract pod ordinal from hostname or secret directory not found' to clarify both potential failure modes.

Suggested change

echo "missing secret directory for pod ordinal ${ordinal}" >&2

echo "Failed to extract pod ordinal from hostname or secret directory not found (ordinal: ${ordinal})" >&2

Copilot · 2026-01-28T06:20:19Z

charts/reconstruction-server/templates/statefulset.yaml

+              export REG_SECRET="$(cat "${secret_dir}/REG_SECRET")"
+              export SECP256K1_PRIVHEX="$(cat "${secret_dir}/SECP256K1_PRIVHEX")"


If either secret file is missing or unreadable, the cat command will fail but the error may not clearly indicate which specific secret file caused the failure. Consider adding explicit checks for each file's existence before reading, or adding better error context (e.g., 'Failed to read REG_SECRET from ${secret_dir}/REG_SECRET').

Suggested change

export REG_SECRET="$(cat "${secret_dir}/REG_SECRET")"

export SECP256K1_PRIVHEX="$(cat "${secret_dir}/SECP256K1_PRIVHEX")"

reg_secret_file="${secret_dir}/REG_SECRET"

if [ ! -r "${reg_secret_file}" ]; then

echo "Failed to read REG_SECRET from ${reg_secret_file}" >&2

exit 1

fi

secp256k1_privhex_file="${secret_dir}/SECP256K1_PRIVHEX"

if [ ! -r "${secp256k1_privhex_file}" ]; then

echo "Failed to read SECP256K1_PRIVHEX from ${secp256k1_privhex_file}" >&2

exit 1

fi

export REG_SECRET="$(cat "${reg_secret_file}")"

export SECP256K1_PRIVHEX="$(cat "${secp256k1_privhex_file}")"

shuning-auki

looks good. have you tried to scale it up and see how they register with DDS, is there any problem with registering the same URL and same credentials?

shuning-auki · 2026-02-06T02:36:05Z

charts/reconstruction-server/values.yaml

  runAsNonRoot: true
  runAsUser: 1000

 deploymentStrategy:


This seems no longer in used

tatiesmars · 2026-02-06T04:02:41Z

looks good. have you tried to scale it up and see how they register with DDS, is there any problem with registering the same URL and same credentials?

This PR need the following one:

which drop the support for URL. As I understand from @robinlindh, we want to allow multiple "worker" operate under the same wallet

feat: support hpa

d767f7f

dataviruset changed the title ~~feat: support hpa~~ feat(reconstruction-server): HPA support Jan 23, 2026

chore(reconstruction-server): remove HPA and validate replicaCount vs…

cb778d0

… pool

tatiesmars requested a review from dataviruset January 27, 2026 02:19

tatiesmars marked this pull request as ready for review January 27, 2026 02:19

tatiesmars changed the title ~~feat(reconstruction-server): HPA support~~ feat(reconstruction-server): single command to scale Jan 27, 2026

tatiesmars requested a review from a team January 27, 2026 02:19

dataviruset requested a review from Copilot January 28, 2026 06:19

Copilot AI reviewed Jan 28, 2026

View reviewed changes

shuning-auki reviewed Feb 6, 2026

View reviewed changes

tatiesmars added 3 commits February 12, 2026 12:53

Merge branch 'main' into feature/support-hpa

8169b16

Merge branch 'main' into feature/support-hpa

7240a36

reconstruction: set app version to v0.3.1

e5777fc

tatiesmars requested review from shuning-auki and removed request for dataviruset March 23, 2026 04:02

tatiesmars merged commit cdca992 into main Mar 23, 2026
6 checks passed

tatiesmars deleted the feature/support-hpa branch March 23, 2026 04:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(reconstruction-server): single command to scale#29

feat(reconstruction-server): single command to scale#29
tatiesmars merged 5 commits intomainfrom
feature/support-hpa

tatiesmars commented Jan 23, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

shuning-auki left a comment •

edited

Loading

Uh oh!

shuning-auki Feb 6, 2026

Uh oh!

tatiesmars commented Feb 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-              ordinal="${HOSTNAME##*-}"
+              if [ -z "${HOSTNAME}" ]; then
+                echo "Expected hostname format: <name>-<ordinal>, but HOSTNAME is empty" >&2
+                exit 1
+              fi
+              case "${HOSTNAME}" in
+                *-[0-9][0-9]*)
+                  ordinal="${HOSTNAME##*-}"
+                  ;;
+                *)
+                  echo "Expected hostname format: <name>-<ordinal>, got '${HOSTNAME}'" >&2
+                  exit 1
+                  ;;
+              esac

	echo "missing secret directory for pod ordinal ${ordinal}" >&2
	echo "Failed to extract pod ordinal from hostname or secret directory not found (ordinal: ${ordinal})" >&2

		export REG_SECRET="$(cat "${secret_dir}/REG_SECRET")"
		export SECP256K1_PRIVHEX="$(cat "${secret_dir}/SECP256K1_PRIVHEX")"

-              export REG_SECRET="$(cat "${secret_dir}/REG_SECRET")"
-              export SECP256K1_PRIVHEX="$(cat "${secret_dir}/SECP256K1_PRIVHEX")"
+              reg_secret_file="${secret_dir}/REG_SECRET"
+              if [ ! -r "${reg_secret_file}" ]; then
+                echo "Failed to read REG_SECRET from ${reg_secret_file}" >&2
+                exit 1
+              fi
+              secp256k1_privhex_file="${secret_dir}/SECP256K1_PRIVHEX"
+              if [ ! -r "${secp256k1_privhex_file}" ]; then
+                echo "Failed to read SECP256K1_PRIVHEX from ${secp256k1_privhex_file}" >&2
+                exit 1
+              fi
+              export REG_SECRET="$(cat "${reg_secret_file}")"
+              export SECP256K1_PRIVHEX="$(cat "${secp256k1_privhex_file}")"

Conversation

tatiesmars commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

shuning-auki left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shuning-auki Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

tatiesmars commented Feb 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tatiesmars commented Jan 23, 2026 •

edited

Loading

shuning-auki left a comment •

edited

Loading