Skip to content

fix: validate Build-protobuf-Library arguments and add smoke tests#131

Open
AdamMomen wants to merge 2 commits intoaukilabs:mainfrom
AdamMomen:bug/build-protobuf-args
Open

fix: validate Build-protobuf-Library arguments and add smoke tests#131
AdamMomen wants to merge 2 commits intoaukilabs:mainfrom
AdamMomen:bug/build-protobuf-args

Conversation

@AdamMomen
Copy link
Copy Markdown

@AdamMomen AdamMomen commented Mar 10, 2026

Summary

  • Added a validation for Build-protobuf-Library.ps1 arguments (Platform, Architecture, BuildType) against allowed values.
  • Made argument matching case‑insensitive and normalize to canonical casing.
  • Added a -DryRun switch so we can exercise argument handling and directory creation without performing a full protobuf build.
  • Introduced a PowerShell smoke test script to guard against regressions of issue #81.
    Details

Tests

Run the smoke tests from the repo root:

pwsh third-party/scripts/Test-Build-protobuf-Library.ps1

This script verifies:

  • Incomplete/invalid arguments fail with a non‑zero exit code and do not create bogus *-web-- directories.
  • Lowercase but fully specified arguments (web wasm32 release -DryRun) work and create the correct canonical directories.
  • Canonical arguments (Web WASM32 Release -DryRun) continue to behave as expected.
  • Non‑Web platform example (linux arm64 release -DryRun) is accepted and normalized correctly.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 10, 2026

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants