Skip to content

feat: support cancellation & cleaner events/stage#9

Merged
tatiesmars merged 2 commits intodevelopfrom
feature/support-cancellation
Feb 27, 2026
Merged

feat: support cancellation & cleaner events/stage#9
tatiesmars merged 2 commits intodevelopfrom
feature/support-cancellation

Conversation

@tatiesmars
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@robinlindh robinlindh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: this versioning code is similar to what we did on reconstruction server or? On the reconstruction server I had an issue that I couldn't actually specify a version like ending with -local (or other non-digits) as it got rejected by the DDS. So the example in readme doesn't actually work. I would like the DDS to support it though. Or maybe it works now?

Other than that all looks good

@tatiesmars
Copy link
Copy Markdown
Contributor Author

Question: this versioning code is similar to what we did on reconstruction server or? On the reconstruction server I had an issue that I couldn't actually specify a version like ending with -local (or other non-digits) as it got rejected by the DDS. So the example in readme doesn't actually work. I would like the DDS to support it though. Or maybe it works now?

Other than that all looks good

This is similar versioning as reconstruction server, and I already did a fix on dds. we should now support v0.0.0-xxxxx version

@robinlindh
Copy link
Copy Markdown
Contributor

Okay, good! Approving

@tatiesmars tatiesmars merged commit 9d7ca1e into develop Feb 27, 2026
4 checks passed
@tatiesmars tatiesmars deleted the feature/support-cancellation branch February 27, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants