Draft
Conversation
- Create UserService and SkillService implementations - Refactor drill API endpoints to use DrillService - Enhance drag manager with improved timeline positioning - Fix section rendering to maintain item order - Update service layer documentation with implementation status - Add specialized service methods for variant management and voting - Improve error handling across service implementations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit fixes an issue where creating a new practice plan with drills from the cart wasn't properly populating the drills in the plan sections. Changes include: 1. Modified PracticePlanForm.svelte to add all cart drills to the "Skill Building" section 2. Added data-testid attribute to DrillItem for better testability 3. Added a new Cypress test to verify the functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…ts, update .gitignore - Moved har_cleaner.py to scripts directory - Removed unused files (DRAG_AND_DROP.md, drills-speedup.txt, table-info.txt, etc.) - Added tests/__pycache__, cypress/downloads, and cypress/screenshots to .gitignore - Added code review documents 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…dead-code-stores.md Update ticket 28 dead code stores
…dead-code-cleanup Remove obsolete admin migration page
# Conflicts: # src/lib/stores/sectionsStore.js
…unctions - Added comprehensive error handling with try-catch blocks - Implemented backup/restore pattern for atomic operations - Added input validation for all parameters - Added user-friendly error messages via toast notifications - Return boolean success/failure indicators - Maintain data integrity on errors by restoring backup 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
- Marked conflict as resolved - Updated Phase 3 with completion status - Removed outdated merge instructions 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Successfully decoupled SectionHeader and TimelineSelectorModal from sectionsStore by passing constants as props. This improves component reusability and testability.
…-filterpanel.md Update FilterPanel basics
- Replace non-existent onErrorCaptured with window error event listeners - Fix production error: "(0 , __vite_ssr_import_1__.onErrorCaptured) is not a function" - Add tabbable package for focus trap functionality - Document PR review progress for Phase 5 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fixed broken admin role checking by updating isAdmin() to fetch from DB - Added setUserRole() method to actually assign admin roles - Fixed admin route protection to check user roles, not just dev mode - Populated user role in session from database in hooks.server.js - Added permission helper functions and middleware - Created admin UI for managing user roles at /admin/users - Added comprehensive tests for new role methods - Fixed test setup for getUserProfile with proper mocking Critical fixes: - Admin routes now properly check user roles - Role is fetched and available in event.locals.user - Admin role can be assigned through UI - Maintains dev mode access while adding proper role-based security 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…efactor-userservice-perms Update UserService refactor ticket
Co-authored-by: austeane <austeane@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a guard to prevent redundant SvelteKit navigations to fix infinite loop and related errors.
The
TypeErrorandRangeErrorwere symptoms of an infinite navigation loop. This occurred because the filter/search logic would rebuild the URL and callgoto()even when the query parameters hadn't changed, leading to rapid, recursive navigations that exceeded the call stack. The added check ensuresgoto()is only called when the URL's search parameters genuinely differ, breaking the loop.Open in Web • Open in Cursor
Learn more about Background Agents