Skip to content

fix: avoid undefined/null values in validityInfo.expectedUpdate #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfromaniello merged 1 commit into from
Mar 26, 2025
+96 −375
Merged

fix: avoid undefined/null values in validityInfo.expectedUpdate #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions __tests__/issuing/deviceResponse.tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ describe('issuing a device response', () => {
expect(validityInfo.signed).toEqual(signed);
expect(validityInfo.validFrom).toEqual(signed);
expect(validityInfo.validUntil).toEqual(validUntil);
expect(validityInfo.expectedUpdate).toBeUndefined();
expect(validityInfo).not.toHaveProperty('expectedUpdate');
});

it('should contain the device namespaces', () => {
Expand Down Expand Up @@ -223,7 +223,7 @@ describe('issuing a device response', () => {
expect(validityInfo.signed).toEqual(signed);
expect(validityInfo.validFrom).toEqual(signed);
expect(validityInfo.validUntil).toEqual(validUntil);
expect(validityInfo.expectedUpdate).toBeUndefined();
expect(validityInfo).not.toHaveProperty('expectedUpdate');
});

it('should contain the device namespaces', () => {
Expand Down
4 changes: 2 additions & 2 deletions __tests__/issuing/deviceResponseWithMac.tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ curves.forEach((c) => {
expect(validityInfo.signed).toEqual(signed);
expect(validityInfo.validFrom).toEqual(signed);
expect(validityInfo.validUntil).toEqual(validUntil);
expect(validityInfo.expectedUpdate).toBeUndefined();
expect(validityInfo).not.toHaveProperty('expectedUpdate');
});

it('should contain the device namespaces', () => {
Expand Down Expand Up @@ -252,7 +252,7 @@ curves.forEach((c) => {
expect(validityInfo.signed).toEqual(signed);
expect(validityInfo.validFrom).toEqual(signed);
expect(validityInfo.validUntil).toEqual(validUntil);
expect(validityInfo.expectedUpdate).toBeUndefined();
expect(validityInfo).not.toHaveProperty('expectedUpdate');
});

it('should contain the device namespaces', () => {
Expand Down
5 changes: 4 additions & 1 deletion __tests__/issuing/issuingMDoc.tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ describe('issuing an MDOC', () => {
validFrom.setMinutes(signed.getMinutes() + 5);
const validUntil = new Date(signed);
validUntil.setFullYear(signed.getFullYear() + 30);
const expectedUpdate = new Date(signed);
expectedUpdate.setFullYear(signed.getFullYear() + 1);

beforeAll(async () => {
const issuerPrivateKey = ISSUER_PRIVATE_KEY_JWK;
Expand Down Expand Up @@ -53,6 +55,7 @@ describe('issuing an MDOC', () => {
signed,
validFrom,
validUntil,
expectedUpdate,
})
.addDeviceKeyInfo({ deviceKey: publicKeyJWK })
.sign({
Expand Down Expand Up @@ -86,7 +89,7 @@ describe('issuing an MDOC', () => {
expect(validityInfo.signed).toEqual(signed);
expect(validityInfo.validFrom).toEqual(validFrom);
expect(validityInfo.validUntil).toEqual(validUntil);
expect(validityInfo.expectedUpdate).toBeUndefined();
expect(validityInfo.expectedUpdate).toEqual(expectedUpdate);
});

it('should use the correct digest alg', () => {
Expand Down
Loading