Skip to content

Conversation

@kushalshit27
Copy link
Contributor

@kushalshit27 kushalshit27 commented Jan 2, 2025

🔧 Changes

Fix: Update SMS factor provider handling for Twilio for guardianFactorProviders

📚 References

https://auth0.com/docs/api/management/v2/guardian/put-sms-twilio-factor-provider

🔬 Testing

  • Unit test pass
  • Integration test pass

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.34%. Comparing base (998fba2) to head (0ceb59a).
Report is 44 commits behind head on master.

Files with missing lines Patch % Lines
...rc/tools/auth0/handlers/guardianFactorProviders.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1007      +/-   ##
==========================================
- Coverage   80.37%   80.34%   -0.04%     
==========================================
  Files         125      125              
  Lines        4546     4548       +2     
  Branches      876      877       +1     
==========================================
  Hits         3654     3654              
- Misses        528      529       +1     
- Partials      364      365       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kushalshit27 kushalshit27 marked this pull request as ready for review January 2, 2025 05:09
@kushalshit27 kushalshit27 requested a review from a team as a code owner January 2, 2025 05:09
@kushalshit27 kushalshit27 merged commit 6e98caa into master Jan 3, 2025
8 checks passed
@kushalshit27 kushalshit27 deleted the DXCDT-797-update-the-sms-twilio branch January 3, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants