Open
Conversation
… test Use page.setCookie with expires: 0 instead of page.deleteCookie for more reliable cookie deletion in CI environments. This approach is more consistent across different Puppeteer environments. Fixes the failing 'should login silently if there is an active session on the IDP' test in GitHub Actions while maintaining local test compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This repo has open PR for node.js 20+ and ESM only which all existing test passing. The next phase for OIDC migration v4 to v6. Before changing runtime behaviour this PR has setup test infrastructure for next steps.
Changes
Does not change any behaviour of repo