Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1917 +/- ##
=======================================
Coverage 83.78% 83.78%
=======================================
Files 11 11
Lines 185 185
Branches 31 31
=======================================
Hits 155 155
Misses 16 16
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pamapa
reviewed
Feb 26, 2026
Member
|
i very much like the idea to support passing args.... |
pamapa
reviewed
Feb 27, 2026
src/useAutoSignin.ts
Outdated
|
|
||
| export function useAutoSignin({ signinMethod = "signinRedirect", args }: { | ||
| signinMethod?: "signinRedirect" | "signinPopup"; | ||
| args?: SigninPopupArgs | SigninRedirectArgs; |
Member
There was a problem hiding this comment.
to be aligned with signinMethod, please rename args to signinArgs
Contributor
Author
|
done, please have a look @pamapa |
Member
|
looks good, once the unit-tests work again i will merge: Error: test/useAutoSignin.test.tsx(61,45): error TS2769: No overload matches this call.
Overload 1 of 3, '(options?: { signinArgs?: SigninRedirectArgs | undefined; } | undefined): UseAutoSignInReturn', gave the following error.
Object literal may only specify known properties, and 'signinMethod' does not exist in type '{ signinArgs?: SigninRedirectArgs | undefined; }'.
Overload 2 of 3, '(options: { signinMethod: "signinRedirect"; signinArgs?: SigninRedirectArgs | undefined; }): UseAutoSignInReturn', gave the following error.
Object literal may only specify known properties, and 'args' does not exist in type '{ signinMethod: "signinRedirect"; signinArgs?: SigninRedirectArgs | undefined; }'.
Overload 3 of 3, '(options: { signinMethod: "signinPopup"; signinArgs?: SigninPopupArgs | undefined; }): UseAutoSignInReturn', gave the following error.
Type '"signinRedirect"' is not assignable to type '"signinPopup"'.
Error: test/useAutoSignin.test.tsx(81,45): error TS2769: No overload matches this call.
Overload 1 of 3, '(options?: { signinArgs?: SigninRedirectArgs | undefined; } | undefined): UseAutoSignInReturn', gave the following error.
Object literal may only specify known properties, and 'signinMethod' does not exist in type '{ signinArgs?: SigninRedirectArgs | undefined; }'.
Overload 2 of 3, '(options: { signinMethod: "signinRedirect"; signinArgs?: SigninRedirectArgs | undefined; }): UseAutoSignInReturn', gave the following error.
Type '"signinPopup"' is not assignable to type '"signinRedirect"'.
Overload 3 of 3, '(options: { signinMethod: "signinPopup"; signinArgs?: SigninPopupArgs | undefined; }): UseAutoSignInReturn', gave the following error.
Object literal may only specify known properties, and 'args' does not exist in type '{ signinMethod: "signinPopup"; signinArgs?: SigninPopupArgs | undefined; }'.
Error: test/useAutoSignin.test.tsx(98,13): error TS2769: No overload matches this call.
Overload 1 of 3, '(options?: { signinArgs?: SigninRedirectArgs | undefined; } | undefined): UseAutoSignInReturn', gave the following error.
Object literal may only specify known properties, and 'args' does not exist in type '{ signinArgs?: SigninRedirectArgs | undefined; }'.
Overload 2 of 3, '(options: { signinMethod: "signinRedirect"; signinArgs?: SigninRedirectArgs | undefined; }): UseAutoSignInReturn', gave the following error.
Object literal may only specify known properties, and 'args' does not exist in type '{ signinMethod: "signinRedirect"; signinArgs?: SigninRedirectArgs | undefined; }'.
Overload 3 of 3, '(options: { signinMethod: "signinPopup"; signinArgs?: SigninPopupArgs | undefined; }): UseAutoSignInReturn', gave the following error.
Object literal may only specify known properties, and 'args' does not exist in type '{ signinMethod: "signinPopup"; signinArgs?: SigninPopupArgs | undefined; }'.
Error: Process completed with exit code 2. |
Contributor
Author
|
Ahh forgot to update the tests, fixed @pamapa |
pamapa
approved these changes
Mar 3, 2026
Member
|
Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1916
Checklist