Skip to content

CLI enhancements #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pferrot wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CLI enhancements #25

pferrot wants to merge 2 commits into from

Conversation

@pferrot
Copy link

@pferrot pferrot commented Mar 25, 2016

  1. Allow to use custom proxy port.
  2. Use the 'requests' module instead of curl. We have seen issues with curl with commands that take some time (e.g. > 30 seconds) where the CLI would hang even if everything completed successfully on the Ochothon side.

Patrice Ferrot added 2 commits March 3, 2016 11:55
Allow to specify custom proxy port.
71516ec
@pferrot
Use 'requests' instead of 'curl'
3ec1f47 
With curl, the command will hang forever with commands that take some
time (e.g. more than 30 seconds), even if everything completed
successfully in Ochothon.
@otakup0pe
Copy link

otakup0pe commented May 18, 2016

Definitely 👍 on using requests rather than shelling out to curl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pferrot @otakup0pe