Removal of unused options from PkgCreator arguments
#114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hundreds of recipes dating from the very beginning of AutoPkg use the
optionskey in thepkg_requestargument of PkgCreator:However, this key doesn't serve any purpose at all. The
optionskey is ignored and not passed along topkgbuild, regardless of its presence or contents. It appears that this has been the case since the very first public release of AutoPkg 0.1.0!So this pull request (one of over 100) formally ends this practice and removes the unused and unneeded
optionskey from all recipes in the AutoPkg org that use PkgCreator.Thanks for considering!
This PR was submitted using Repo Lasso v1.2.0.