Open
Conversation
Looks like benchmarks are superseded by examples/benchmarks.rs and should be removed altogether, but while they are here they should at least compile cleanly. Well, now benches compile but panic on tensor dimension mismatch.
|
There were the following issues with your Pull Request
Guidelines are available at https://github.com/autumnai/leaf/blob/develop/CONTRIBUTING.md#git-commit-guidelines This message was auto-generated by https://gitcop.com |
…e() [SKIP_CHANGELOG]
alexandermorozov
force-pushed
the
pr-cleanup-vecs
branch
from
c57172b to
b1e3879
Compare
Collaborator
|
☔ The latest upstream changes (presumably #85) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #85 and autumnai/collenchyma#57.
It replaces &vec![...] with &[...] where appropriate. I think it's a good change since it removes unneeded allocations and makes lines a bit shorter )
The patch also removes one redundant .clone() call.
If you think that PR to collenchyma isn't worth it, I can change this PR to use tuples instead of arrays.
Edit: travis'll fail this commit until collenchyma's PR is merged and crate published.