Change the library to support download only requests #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alaayameen
suggested changes
Jan 16, 2017
| key = bucket.get_key(key_path) | ||
|
|
||
| if not key: | ||
| raise FilesystemError("File is not Found") |
| return [] | ||
|
|
||
| def isfile(self, path): | ||
| return True |
There was a problem hiding this comment.
why this always returns True ? also the same for islink and isdir
Author
There was a problem hiding this comment.
Thanks @alaayameen, this modification is meant to overwrite the default settings and only serve files, directories unsupported.
| self.conn.get_all_buckets() | ||
| except boto.exception.S3ResponseError: | ||
| def validate_authentication(self, username, password, handler): | ||
| if username == settings.FTP_USERNAME and password == settings.FTP_PASSWORD: |
There was a problem hiding this comment.
You should use asserts for settings
Author
There was a problem hiding this comment.
Thanks @alaayameen, I don't think it will work this way because this should respond with FTP standers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.