Skip to content

Conversation

@SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Nov 22, 2025

Also check module-path first

@SentryMan SentryMan added this to the 4.3 milestone Nov 22, 2025
@SentryMan SentryMan requested a review from rbygrave November 22, 2025 23:13
@SentryMan SentryMan self-assigned this Nov 22, 2025
@SentryMan SentryMan added the enhancement New feature or request label Nov 22, 2025
@SentryMan SentryMan enabled auto-merge November 22, 2025 23:13
@SentryMan SentryMan changed the title Catch NCDF instead of using Class.forName Replace Class.forName with Module Check and Direct Load Nov 23, 2025
@rbygrave
Copy link
Contributor

I'm looking to do a check with GraalVM build time initialisation to see if this should adjust to better support that (native image built time initialisation of the YamlParser). As in, if we pull out this initialisation into another class and build time initialise it, is that a positive feature to look to support or is it not worth it (as the initialisation cascades etc).

@SentryMan
Copy link
Collaborator Author

SentryMan commented Nov 24, 2025

I'm looking to do a check with GraalVM build time initialisation

I feel like this works better as a fast follow-up rather than to delay the immediate benefits of this PR's improvements. It does sound interesting though

@rbygrave
Copy link
Contributor

Did I miss the immediate benefit? Are you needing an avaje-config RC release? To me it looks like a minor performance improvement if Snake YAML is on the classpath. Is there another benefit I missed? (As in, I'll look to sort out the graal thing in a couple of days. I don't think it's great to churn the avaje-config version too frequently because LOTS of things depend on it, so a couple of days to sort this is imo a good thing to not churn avaje-config releases).

@SentryMan
Copy link
Collaborator Author

I don't think it's great to churn the avaje-config version too frequently

I see, it can wait then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants