-
Notifications
You must be signed in to change notification settings - Fork 9
Replace Class.forName with Module Check and Direct Load
#231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Class.forNameClass.forName with Module Check and Direct Load
|
I'm looking to do a check with GraalVM build time initialisation to see if this should adjust to better support that (native image built time initialisation of the YamlParser). As in, if we pull out this initialisation into another class and build time initialise it, is that a positive feature to look to support or is it not worth it (as the initialisation cascades etc). |
I feel like this works better as a fast follow-up rather than to delay the immediate benefits of this PR's improvements. It does sound interesting though |
|
Did I miss the immediate benefit? Are you needing an avaje-config RC release? To me it looks like a minor performance improvement if Snake YAML is on the classpath. Is there another benefit I missed? (As in, I'll look to sort out the graal thing in a couple of days. I don't think it's great to churn the avaje-config version too frequently because LOTS of things depend on it, so a couple of days to sort this is imo a good thing to not churn avaje-config releases). |
I see, it can wait then |
Also check module-path first