Address Responses review comments#250
Open
emal-avala wants to merge 1 commit intomainfrom
Open
Conversation
emal-avala
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
response.incomplete/ incompleteresponse.completedpayloads withincomplete_details.reason = "max_output_tokens"asStopReason::MaxTokens, so the existing max-output recovery path can run.Review comments addressed
Test plan
cargo test -p agent-code-lib openai::testscargo check --all-targetscargo clippy --all-targets -- -D warningscargo fmt --all -- --checkcargo run -p agent-code -- --auth-mode codex_chatgpt --model gpt-5.4 --prompt "Reply with exactly: ok" --max-turns 2 --verboseNote: I verified the ChatGPT Codex backend currently rejects
max_output_tokens,max_completion_tokens, andmax_tokenswithUnsupported parameter, so this PR does not add those fields to the Codex auth Responses payload.