Skip to content

Fix duplicate scrobbling when switching to radio streams #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avelytchko merged 1 commit into from
Jan 17, 2026
Merged

Fix duplicate scrobbling when switching to radio streams #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions foobar2000/foo_mac_scrobble/play_callback.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ class scrobble_callback : public play_callback_static
if (!(m_length > 0.0 && std::isfinite(m_length)))
{
console::print("Last.fm Scrobbler: Track length invalid or missing, skipping.");
// Clear current track data to prevent re-scrobbling when switching to streams
m_current_track = LastfmApi::TrackInfo();
m_scrobbled = false;
m_threshold = 0;
return;
}

Expand Down Expand Up @@ -132,6 +136,10 @@ class scrobble_callback : public play_callback_static
if (!cfg_enabled.get() || m_scrobbled || p_time < m_threshold)
return;

// Don't scrobble if current track data is empty (e.g., after switching to radio streams)
if (m_current_track.artist.empty() || m_current_track.track.empty())
return;

try
{
static_api_ptr_t<playback_control> playback_control;
Expand Down Expand Up @@ -175,6 +183,8 @@ class scrobble_callback : public play_callback_static
m_scrobbled = false;
m_length = 0;
m_threshold = 0;
// Clear current track data to prevent stale data from being used
m_current_track = LastfmApi::TrackInfo();
}

void on_playback_pause(bool p_state) override
Expand Down