fix: README intro + jdtls initialize timeout for large monorepos#45
Merged
aviadshiber merged 1 commit intomainfrom Apr 10, 2026
Merged
fix: README intro + jdtls initialize timeout for large monorepos#45aviadshiber merged 1 commit intomainfrom
aviadshiber merged 1 commit intomainfrom
Conversation
The numbered list has three items (language support, rules, code actions) but the intro said "two things in one". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
aviadshiber
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes:
1. README: "two things" → "three things"
The intro listed three items but said "two things in one".
2. jdtls initialize timeout: 30s → 120s
jdtls was timing out during initialization on large Maven monorepos (e.g.,
productswith hundreds of modules). The defaultREQUEST_TIMEOUT = 30swas used for theinitializehandshake, but jdtls needs to scan pom.xml files, resolve classpaths, and build its index — easily exceeding 30s on large workspaces.Added
INITIALIZE_TIMEOUT = 120sused only for theinitializerequest. Normal request timeout stays at 30s.Why e2e tests didn't catch this: Tests use a tiny single-file workspace (
Hello.java) that initializes in <2s. The timeout only manifests on real-world monorepos.Test plan
🤖 Generated with Claude Code