respect branchNamePrefix config in all branch creation paths #653

willschnicke-silkline · 2026-01-22T19:46:15Z

The branchNamePrefix config setting was only being used when auto-generating
branch names via av commit -b, but not when using av branch directly or
av branch --split to split commits.

Now the prefix is applied consistently across all branch creation commands by
centralizing the logic in a single applyBranchNamePrefix helper function.
When branches are created (whether explicitly named or auto-generated), the
configured prefix gets prepended.

Changes

Added applyBranchNamePrefix() helper function to centralize prefix logic
Applied prefix in createBranch() for av branch <name>
Applied prefix in branchSplit() for av branch --split
Removed duplicate prefix logic from branchNameFromMessage() in commit.go
Updated test repos to explicitly set empty branchNamePrefix to avoid interference from global config

Testing

All existing tests pass
Added comprehensive test coverage for branch name prefix behavior across all creation paths

The branchNamePrefix config setting was only being used when auto-generating branch names via `av commit -b`, but not when using `av branch` directly or `av branch --split` to split commits. Now the prefix is applied consistently across all branch creation commands by centralizing the logic in a single `applyBranchNamePrefix` helper function. When branches are created (whether explicitly named or auto-generated), the configured prefix gets prepended. To ensure tests aren't affected by developers' global av config, test repos now explicitly set an empty branchNamePrefix in their local config. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

aviator-app · 2026-01-22T19:46:20Z

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

aviator-app · 2026-01-22T19:46:23Z

🔃 FlexReview Status

Common Owner: aviator-co/engineering (expert-load-balance assignment)
Owner and Assignment:

🔒 aviator-co/engineering (expert-load-balance assignment)
- Slack: #av-slack-testing
- Assigned: davi-maciel
Owned Files
- 🔒 e2e_tests/branch_name_prefix_test.go
- 🔒 cmd/av/branch.go
- 🔒 cmd/av/commit.go
- 🔒 internal/git/gittest/repo.go

Review SLO: 7 business hours if PR size is <= 200 LOC for the first response.

gemini-code-assist · 2026-01-22T19:46:36Z

Summary of Changes

Hello @willschnicke-silkline, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an inconsistency where the branchNamePrefix configuration was not uniformly applied across all branch creation methods. By centralizing the prefix application logic into a single function, the system now ensures that all new branches, whether explicitly named or auto-generated through commands like av branch, av branch --split, or av commit -b, correctly adhere to the configured naming convention. This change improves the predictability and reliability of branch naming within the av CLI tool.

Highlights

Centralized Branch Naming Logic: Introduced a new helper function, applyBranchNamePrefix(), to centralize the logic for applying configured branch name prefixes.
Consistent Prefix Application: Ensured the branchNamePrefix configuration is consistently applied across all branch creation commands, including av branch <name>, av branch --split, and av commit -b.
Code Simplification: Removed redundant and duplicate branch name prefix application logic from cmd/av/commit.go, leading to cleaner and more maintainable code.
Enhanced Test Coverage: Added comprehensive end-to-end tests to verify the correct and consistent behavior of branch name prefixes in various creation scenarios.
Improved Test Environment Isolation: Updated test repository setup to explicitly set an empty branchNamePrefix in test configurations, preventing interference from global settings during tests.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

willschnicke-silkline · 2026-01-22T19:48:01Z

internal/git/gittest/repo.go

+pullRequest:
+    branchNamePrefix: ""


my global av setting was conflicting, causing tests to fail. let me know if there is a more correct way to do this!

gemini-code-assist

Code Review

This pull request effectively centralizes the branchNamePrefix logic to ensure consistent application across all branch creation commands. The new applyBranchNamePrefix helper is a clean solution, and the removal of duplicated code improves maintainability. The added end-to-end tests are comprehensive and cover the intended changes well. I have a couple of suggestions to further improve the new test code for robustness and maintainability.

e2e_tests/branch_name_prefix_test.go

willschnicke-silkline · 2026-01-22T19:48:44Z

cmd/av/commit.go

 	name = strings.ToLower(name)
-	if config.Av.PullRequest.BranchNamePrefix != "" {
-		name = fmt.Sprintf("%s%s", config.Av.PullRequest.BranchNamePrefix, name)
-	}


now handled in branch.go

- Extract common test setup logic into setupRepoWithPrefix helper function - Use exact branch name assertions instead of Contains for more robust tests - Reduces code duplication across all test functions Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

willschnicke-silkline · 2026-01-22T19:55:47Z

/gemini review

gemini-code-assist

Code Review

This pull request does a great job of refactoring the branch name prefix logic to be consistent across all branch creation paths. The introduction of the applyBranchNamePrefix helper function is a clean way to centralize this functionality. The removal of the old, duplicated logic and the addition of comprehensive E2E tests significantly improve the codebase's maintainability and correctness. The update to test configurations to ensure isolation is also a welcome improvement. I have one suggestion to further enhance consistency in branch name generation.

willschnicke-silkline requested a review from a team as a code owner January 22, 2026 19:46

aviator-app bot requested a review from davi-maciel January 22, 2026 19:46

willschnicke-silkline commented Jan 22, 2026

View reviewed changes

gemini-code-assist bot reviewed Jan 22, 2026

View reviewed changes

e2e_tests/branch_name_prefix_test.go Outdated Show resolved Hide resolved

e2e_tests/branch_name_prefix_test.go Outdated Show resolved Hide resolved

willschnicke-silkline commented Jan 22, 2026

View reviewed changes

gemini-code-assist bot reviewed Jan 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

respect branchNamePrefix config in all branch creation paths #653

respect branchNamePrefix config in all branch creation paths #653

willschnicke-silkline commented Jan 22, 2026

Uh oh!

aviator-app bot commented Jan 22, 2026

Uh oh!

aviator-app bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Jan 22, 2026

Uh oh!

willschnicke-silkline Jan 22, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

willschnicke-silkline Jan 22, 2026

Uh oh!

willschnicke-silkline commented Jan 22, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		pullRequest:
		branchNamePrefix: ""

respect branchNamePrefix config in all branch creation paths #653

Are you sure you want to change the base?

respect branchNamePrefix config in all branch creation paths #653

Conversation

willschnicke-silkline commented Jan 22, 2026

Changes

Testing

Uh oh!

aviator-app bot commented Jan 22, 2026

Current Aviator status

How to merge

Uh oh!

aviator-app bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔃 FlexReview Status

Uh oh!

gemini-code-assist bot commented Jan 22, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

willschnicke-silkline Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

willschnicke-silkline Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

willschnicke-silkline commented Jan 22, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

aviator-app bot commented Jan 22, 2026 •

edited

Loading