feat(i18n): add full internationalization support (EN/IT)#202
Open
f-liva wants to merge 8 commits intoavihaymenahem:mainfrom
Open
feat(i18n): add full internationalization support (EN/IT)#202f-liva wants to merge 8 commits intoavihaymenahem:mainfrom
f-liva wants to merge 8 commits intoavihaymenahem:mainfrom
Conversation
Add i18next-based internationalization with English and Italian translations. Infrastructure: - i18next + react-i18next with static JSON imports (9 namespaces) - OS locale detection via Tauri plugin-os for accurate system language - Language selector in Settings with "Default (system)" option - SQLite-persisted language preference - Translation completeness test ensuring EN/IT key parity Converted ~30 component files (~500 strings) across layout, email, composer, search, settings, accounts, tasks, and notification layers. Out of scope for Phase 1: helpContent.ts, Rust tray menu, calendar and attachment components, sub-editors (filter/label/signature/template), RTL support, additional languages. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Translate the 3 built-in smart folders (Unread, Has Attachments, Starred This Week) using i18n keys keyed by folder ID. User-created smart folders still show their custom DB name. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Internationalize ~37 component files across settings sub-editors,
calendar, attachments, email sub-components, help page, DnD, and
label form. Add 3 new namespaces (calendar, attachments, help) with
~820 translation keys in EN/IT. Refactor helpContent.ts from literal
strings to i18n key paths. Language selector now shows detected
system language name ("Default (English)" / "Default (Italiano)").
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
f-liva
changed the title
The CSP img-src directive only whitelisted specific domains (Gravatar, Google), causing the browser to block all other remote image requests regardless of the "Block Remote Images" application setting. Added https: and http: to img-src so images load when the user disables the blocking setting. Closes avihaymenahem#197 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Category names in ThreadCard badge, notification settings, and bundle rules were displayed as raw English strings. Now resolved via sidebar namespace translations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
Hey @avihaymenahem, could you please take a look at this PR when you get a chance? It's been open for a couple of weeks and is ready for review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npx tsc --noEmit— 0 errorsnpm run test— 134 files, 1608 tests, all passing🤖 Generated with Claude Code