fix: use UTC methods in iCal all-day date formatting#219
Open
edvintb wants to merge 1 commit intoavihaymenahem:mainfrom
Open
fix: use UTC methods in iCal all-day date formatting#219edvintb wants to merge 1 commit intoavihaymenahem:mainfrom
edvintb wants to merge 1 commit intoavihaymenahem:mainfrom
Conversation
formatDateOnly used local time methods (getDate/getMonth/getFullYear), causing all-day events to be off by one day in negative UTC offset timezones when the input is a UTC midnight timestamp. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
edvintb
force-pushed
the
fix/ical-allday-utc
branch
from
8cb8688 to
ff9ba9e
Compare
Contributor
Author
|
Hey! Quick bump on this one — it's a 3-line fix for all-day events showing on the wrong date in negative UTC offsets. Would love to get it in when you have a sec 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatDateOnly()used local time methods (getDate,getMonth,getFullYear), causing all-day CalDAV events to be off by one day in negative UTC offset timezonesgetUTCFullYear,getUTCMonth,getUTCDate)Test plan
icalHelper.test.tsall-day event test now passes (30/30 tests green)🤖 Generated with Claude Code