fix: enable link clicks in email iframe on macOS#230
Open
edvintb wants to merge 2 commits intoavihaymenahem:mainfrom
Open
fix: enable link clicks in email iframe on macOS#230edvintb wants to merge 2 commits intoavihaymenahem:mainfrom
edvintb wants to merge 2 commits intoavihaymenahem:mainfrom
Conversation
formatDateOnly used local time methods (getDate/getMonth/getFullYear), causing all-day events to be off by one day in negative UTC offset timezones when the input is a UTC midnight timestamp. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
WebKit blocks parent-attached event handlers in sandboxed iframes without allow-scripts. Add allow-scripts to the iframe sandbox — DOMPurify already strips all <script> tags and event handler attributes, so no email JavaScript can execute. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allow-scriptsto the email iframe sandbox so link click handlers work on WebKit/macOS<script>tags and event handler attributes — no email JavaScript can executeTest plan
<script>tags)🤖 Generated with Claude Code