Update bad.json and generator.js #1
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two updates. My apologies for them being grouped together. GitHub did it, : )
The first,
bad.json. Feel free to discard this PR if it goes against your plan for the project. The goal of this PR is to try to group together alternate spellings and remove redundancies.For example, if generated passwords with the word porn are discarded, then there is no need to further search for porno and pornography. There is also no need to search for plural versions of bad words when the singular versions are already in the list.
The second,
generator.js. I see that when bad words are found, a new password is generated, but it is being generated on top of the last generated password without restarting the search for bad words. That makes it possible to have a regenerated password use a bad word from earlier in the bad words list.