Skip to content

Conversation

@dangowans
Copy link

@dangowans dangowans commented Jul 29, 2020

Two updates. My apologies for them being grouped together. GitHub did it, : )

The first, bad.json. Feel free to discard this PR if it goes against your plan for the project. The goal of this PR is to try to group together alternate spellings and remove redundancies.

For example, if generated passwords with the word porn are discarded, then there is no need to further search for porno and pornography. There is also no need to search for plural versions of bad words when the singular versions are already in the list.

The second, generator.js. I see that when bad words are found, a new password is generated, but it is being generated on top of the last generated password without restarting the search for bad words. That makes it possible to have a regenerated password use a bad word from earlier in the bad words list.

trying to sort the alternate spellings, and remove redundancies
fix case where early bad words could be missed
@dangowans dangowans changed the title Update bad.json Update bad.json and generator.js Jul 29, 2020
@dangowans
Copy link
Author

In regards to the generator.js update, I misspoke. It's not that bad words will be missed if the password needs to be regenerated. Rather, the bad words list will be scanned on the final password multiple times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant