Skip to content

Bugfix/zi 13898 device id null in some cases #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
avwave wants to merge 2 commits into
base: staging
Choose a base branch
from
Draft

Bugfix/zi 13898 device id null in some cases #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cce257
ZI-13898
May 25, 2023
3399499
ZI-13898
May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/components/Fingerprint/Fingerprint.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ const useStyles = makeStyles()((theme) => {
let fpPromise = null

const registerFingerprint = async () => {
fpPromise = FingerprintJS.load({
monitoring: false,
})
const fp = await localStorage.getItem('fingerprint')
if (isEmpty(fp)) {
await localStorage.setItem('fingerprint', uuidv4())
}
fpPromise = FingerprintJS.load({
monitoring: false,
})
}

const useFingerprint = async () => {
Expand All @@ -40,6 +40,10 @@ const Fingerprint = ({ guid=false, onFingerprint = () => { } }) => {
const { classes } = useStyles()

useEffect(() => {
if (guid) {
onFingerprint(localStorage.getItem('fingerprint'))
return
}
if (!fpPromise) throw new Error('FingerprintJS not loaded, add registerFingerprint() closest to root as possible (possibly index.js)')
const fetchFP = async () => {
const fp = await fpPromise
Expand Down