Skip to content

Feature/zi 11896 formbuilder bug not displaying subform errors/check single instance validity for arrays #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
avwave wants to merge 7 commits into
base: staging
Choose a base branch
from
Draft

Feature/zi 11896 formbuilder bug not displaying subform errors/check single instance validity for arrays #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
23a8a16
ZI-11896 formbuilder bug: not displaying subform errors/check single …
avwave Jun 8, 2022
1cf6af9
ZI-11896 check for obj strings
avwave Jun 8, 2022
3e80e92
ZI-11896 check for obj strings
avwave Jun 8, 2022
c28ef3b
ZI-11896 check for obj strings
avwave Jun 8, 2022
4a173ca
ZI-11896 check for obj strings
avwave Jun 8, 2022
983fec2
ZI-11896 check for obj strings
avwave Jun 8, 2022
710ba18
ZI-11896 check for obj strings
avwave Jun 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/components/FormBuilder/FormBuilder.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,6 +847,13 @@ const FormFieldSet = ({
const isFormInline = formInline && field?.type !== 'component'
if (field) {
const err = get(formik.touched, layout) && get(formik.errors, layout);
const errText = Array.isArray(err) ? Array.from(new Set(err)).join(', ') : err;
const isErrArrString = Array.isArray(err) ? err?.reduce((acc, curr) => {
return acc || (typeof curr === 'string' || curr instanceof String)
}, false): false;

const isErrString = isErrArrString || (typeof err === 'string' || err instanceof String)

const growFactor = ((field.forceColumnWidth ?? 0) === 0) ? {} : { sm: field.forceColumnWidth }
return (
<Grid
Expand All @@ -867,7 +874,7 @@ const FormFieldSet = ({
>
{renderField(layout, field, fieldName)}
<FormHelperText>
{!Array.isArray(err) ? err : ""}
{isErrString ? errText: ""}
</FormHelperText>
</FormControl>
</div>
Expand Down
4 changes: 2 additions & 2 deletions src/components/FormBuilder/index.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,9 +474,9 @@ Duration.args = {
duration: {
type: "duration",
label: "Duration",
initialValues: 60400,
initialValues: '',
validator: () =>
Yup.number().required().nullable()
Yup.number().required().label()
},
},
formId: "duration",
Expand Down