Skip to content

feat(appstore): support 1.21 - add more fields to JWSTransaction#333

Merged
takecy merged 2 commits intoawa:masterfrom
richzw:master
Apr 29, 2026
Merged

feat(appstore): support 1.21 - add more fields to JWSTransaction#333
takecy merged 2 commits intoawa:masterfrom
richzw:master

Conversation

@richzw
Copy link
Copy Markdown
Collaborator

@richzw richzw commented Apr 29, 2026

New features

…monthly subscriptions with a 12-month commitment
Copilot AI review requested due to automatic review settings April 29, 2026 06:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

App Store Server API v1.21 相当の追加フィールド対応として、Advanced Commerce 関連のデータ型を追加し、JWSTransaction のデコード payload に新しいフィールドを取り込めるようにするPRです。

Changes:

  • Advanced Commerce の返金・取引情報(refund / items / period / transactionInfo)に関する型定義を追加
  • BillingPlanTypeTransactionCommitmentInfo を追加
  • JWSTransactionadvancedCommerceInfo / billingPlanType / commitmentInfo を追加

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread appstore/api/model.go
Comment thread appstore/api/model.go
Comment thread appstore/api/model.go
Comment thread appstore/api/model.go
Copy link
Copy Markdown
Member

@takecy takecy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR.

JWSTransactionDecodedPayload to support monthly subscriptions with a 12-month commitment: TransactionCommitmentInfo and billingPlanType

LGTM 👍

and the following fields in JWSRenewalInfoDecodedPayload: RenewalCommitmentInfo and renewalBillingPlanType.

Is this not included? 🤔
Did you forget to push it?

@richzw
Copy link
Copy Markdown
Collaborator Author

richzw commented Apr 29, 2026

Thanks for PR.

JWSTransactionDecodedPayload to support monthly subscriptions with a 12-month commitment: TransactionCommitmentInfo and billingPlanType

LGTM 👍

and the following fields in JWSRenewalInfoDecodedPayload: RenewalCommitmentInfo and renewalBillingPlanType.

Is this not included? 🤔 Did you forget to push it?

My bad, missing those two fields before, and update them now.

Copy link
Copy Markdown
Member

@takecy takecy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !
LGTM 👍

@takecy takecy merged commit dec4e96 into awa:master Apr 29, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants