Skip to content

Fix Windows build failure in rotator module #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aweeri merged 3 commits into from
Mar 21, 2026
Merged

Fix Windows build failure in rotator module #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5340c92
fix Windows build failure in rotator module
sandrwich Mar 19, 2026
757dd36
improve installer icon generation
sandrwich Mar 19, 2026
5eb7b7c
add pre-generated logo.ico as fallback for broken ImageMagick
sandrwich Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ windows-arm64: bin/TLEscope.exe

win-installer: windows
@echo "Building Windows installer..."
convert logo.png $(DIST_WIN)/logo.ico 2>/dev/null || echo "Warning: ImageMagick not installed, skipping .ico generation"
magick logo.png -define icon:auto-resize=256,64,48,32,16 $(DIST_WIN)/logo.ico || convert logo.png -define icon:auto-resize=256,64,48,32,16 $(DIST_WIN)/logo.ico || cp logo.ico $(DIST_WIN)/
makensis installer.nsi
@echo "Installer built at dist/TLEscope-Installer.exe"

Expand Down
Binary file added logo.ico
View file
Open in desktop
Binary file not shown.
7 changes: 6 additions & 1 deletion src/rotator.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
#define _GNU_SOURCE
#if defined(_WIN32) || defined(_WIN64)
#define WIN32_LEAN_AND_MEAN
#define NOGDI
#define NOUSER
typedef struct tagMSG *LPMSG;
#endif
#include "rotator.h"
#include "astro.h"
#include <math.h>
Expand All @@ -9,7 +15,6 @@
#if defined(_WIN32) || defined(_WIN64)
#include <winsock2.h>
#include <ws2tcpip.h>
#include <windows.h>
#else
#include <arpa/inet.h>
#include <netdb.h>
Expand Down
Loading