This repository was archived by the owner on Sep 5, 2025. It is now read-only.
Merge pull request #228 from EkoJr/issue-201 #201#228
Open
EkoJR wants to merge 1 commit intoawesomemotive:developmentfrom
Open
Merge pull request #228 from EkoJr/issue-201 #201#228EkoJR wants to merge 1 commit intoawesomemotive:developmentfrom
EkoJR wants to merge 1 commit intoawesomemotive:developmentfrom
Conversation
The Alert occures when SimpleMap > General Options page is loaded, and when Geocode Address button is pressed. A listener function and a check was added. Unfortunatly, the callback function for GeoCoder wasn't initiating when no API Key was used.
|
This is tested and is good. See issue #201 for comments regarding whether something can be displayed if someone tries to geocode an address after the API key has been added but before the settings have been saved. |
|
This is ready for the code review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.