This repository was archived by the owner on Sep 5, 2025. It is now read-only.
Added Styling to TinyMCE #24 PR #243 from EkoJr/sc-button-styling#243
Open
EkoJR wants to merge 3 commits intoawesomemotive:shortcode-buttonfrom
Open
Added Styling to TinyMCE #24 PR #243 from EkoJr/sc-button-styling#243EkoJR wants to merge 3 commits intoawesomemotive:shortcode-buttonfrom
EkoJR wants to merge 3 commits intoawesomemotive:shortcode-buttonfrom
Conversation
EkoJR
changed the title
|
@EkoJR There are two dashicons we can use instead of using an external icon from Awesome Fonts. Here are the dashicons we can use: https://developer.wordpress.org/resource/dashicons/#location I prefer the second one because thats the dashicon we use for the main plugin menu. Can you update your code to remove the use of an external icon and use this dashicon instead. |
Contributor
Author
|
@wpsmort Ok, I wasn't sure at the time, and I posted a reply regarding it. I'll replace the Dashicon with the intended one. |
|
This is tested and is ready for code review. |
Contributor
Author
|
Realized I had forgotten that I added a CSS file to enqueue previously, so I ended making a quick change to remove it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for issue #24